util, debugger: remove internalUtil.error #11448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
debugger
util
targos
approved these changes
Feb 18, 2017
cjihrig
approved these changes
Feb 18, 2017
lpinca
approved these changes
Feb 19, 2017
The internalUtil.error() function was only used by _debugger.js.
jasnell
force-pushed
the
remove-internal-util-error
branch
from
72e1798 to
ebe74ba
Compare
jasnell
added a commit
that referenced
this pull request
Feb 19, 2017
The internalUtil.error() function was only used by _debugger.js. PR-URL: #11448 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in bc44d2c |
addaleax
pushed a commit
that referenced
this pull request
Feb 22, 2017
The internalUtil.error() function was only used by _debugger.js. PR-URL: #11448 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
|
This would need a backport PR to land in v6 or v4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internalUtil.error() function was only used by _debugger.js.
Remove it!
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
util, debugger